fix: group floating window

[TwIStOy]

What kind of change does this PR introduce?

• Fix

Did this PR introduce a breaking change?

A breaking change includes anything that breaks backwards compatibility either at compile or run time.

• No

close #2524

[fredizzimo]

Thanks, I will look into this in the evening. It's possible that we will also put the grouping across layers as an experimental feature toggle, to avoid issues like:

• Float background transparent #2574

I personally think that floating windows should never be grouped across layers, even if some plugins rely on that currently. But it should be possible to write all those UIs using a single layer, which IMO is a better than our unannounced convention of grouping all consecutive layers together. That way only a few plugins need to adopt, maybe only nui and telescope.

[github-actions]

Test Results

  6 files  ±0    6 suites  ±0   18s ⏱️ -6s
110 tests ±0  110 ✅ ±0  0 💤 ±0  0 ❌ ±0 
644 runs  ±0  644 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0f2fc59. ± Comparison against base commit a5b5ae6.

[fredizzimo]

Yes, sorting is needed here, otherwise group_by will create multiple groups for the same group id. That explains the random behaviour of the bug, since the order of the window depend on the window size and maybe even random factors.