fix: don't group floating windows unless one is fully contained in the other #2527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
This is an attempt to make it less likely that floating windows with consecutive z-indexes are rendered together if they shouldn't be rendered together, like the first screenshot in #2502.
Instead of checking if the window rects intersect, I check if one is contained in the other. This isn't foolproof, because we could still have windows with consecutive indexes that should not be rendered together (like the first screenshot in #2502, but in a bigger directory), so the whole window grouping thing needs a lot more thought, and should probably be able to be disabled entirely by an option.
Still, I can't think of any time it would make sense to render two windows with consecutive z-indexes together if one isn't fully contained in the other.