feat: Configurable contrast and gamma #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2024
fredizzimo
changed the title
fredizzimo
force-pushed
the
fsundvik/text-gamma
branch
from
089dc0b
to
9207f19
Compare
fredizzimo
changed the title
|
For a technical overview of what this actually does, see: |
Full hinting is a bit too aggressive, especially with fractional font sizes
fredizzimo
force-pushed
the
fsundvik/text-gamma
branch
from
9207f19
to
49f5096
Compare
|
I think the default hinting needs to be changed to On Linux, Wayland at least on my monitor, I often prefer slight due to the slightly improved quality, but I think none is OK on that as well. |
|
I changed the default hinting to |
zbyna
pushed a commit
to zbyna/neovide
that referenced
this pull request
May 17, 2024
* Configurable text contrast and gamma * Explicitly specify the colorspace to use * Change default hinting to slight Full hinting is a bit too aggressive, especially with fractional font sizes * Update the documentation * Cargo fmt * Set font hinting none as default --------- Co-authored-by: Kaylee Simmons <[email protected]> # Conflicts: # website/docs/configuration.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A recent Skia update made it possible to configure the gamma and the contrast of the rendered text. So this makes that configurable from the Neovide side. The defaults have been chosen to give readable text on all backgrounds and an accurate color representation. But it can be changed to be similar to your favourite terminal for example.
Here are some screenshots for comparison (make sure to open the images in full size)
Neovide main (with fractional font size support (#2500)
This PR
Alacritty
Wezterm
Kitty
Foot
Neovide emulating alacritty (gamma 0.8, contrast 0.1)
As you can see different terminals render the text very differently. And IMO Neovide has always been among the better ones, especially when you take into account different colors and backgrounds, and that further improves it.
The default hinting has also been changed from full to slight. Full makes the text too bold, and sometimes distorts the text too much.
Closes these for good
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Notes