Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Use points instead of pixels for the config file #2476

Merged
merged 1 commit into from May 11, 2024

Conversation

fredizzimo
Copy link
Member

@fredizzimo fredizzimo commented Apr 8, 2024

What kind of change does this PR introduce?

  • The width and size arguments in the font config are now read as points, like guifont and almost any other software.

Did this PR introduce a breaking change?

Yes, users that have adjusted their size in pixels will now see too big fonts.

@fredizzimo fredizzimo changed the title fix!: Fix some issues with the new font config fix!: Use points instead of pixels for the config file May 11, 2024
@fredizzimo fredizzimo marked this pull request as ready for review May 11, 2024 23:27
@fredizzimo fredizzimo force-pushed the fsundvik/fix-config-font-size branch from f7369b1 to 822a48e Compare May 11, 2024 23:31
Copy link

Test Results

  6 files  ±0    6 suites  ±0   18s ⏱️ ±0s
110 tests ±0  110 ✅ ±0  0 💤 ±0  0 ❌ ±0 
644 runs  ±0  644 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 822a48e. ± Comparison against base commit db8fdb2.

@Kethku Kethku merged commit 90d8215 into neovide:main May 11, 2024
12 checks passed
@fredizzimo
Copy link
Member Author

fredizzimo commented May 13, 2024

Hm.. It looks like there was some wrongly resolved merge conflicts or something, because the font config file is still in pixels rather than points. My main branch wasn't updated correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants