Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background image #2419
base: main
Are you sure you want to change the base?
Add background image #2419
Changes from 6 commits
f34d19b
47f7603
7266621
b93761b
ca66c9b
98f6a14
7ff523f
6bf351f
798c68a
266c9c2
2c422f7
c6be61d
b6bfaa9
91becdb
de0f502
da0ab06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be able to use
Canvas::base_layer_size
instead of passingwidth
andheight
by parameter?(fwiw you can look up the things available in
skia_safe
on skia.org, e.g. [SkCanvas::getBaseLayerSize
] corresponds toCanvas::base_layer_size
. The docs forskia_safe
are available directly by runningcargo doc --open
locally)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest renderer changes using
base_layer_size
makes things much more cleaner however it doesn't cover full screen. There is some space left in the bottom that isn't covered by the image.I don't think it's very critical but it would be nice if image could cover the whole screen. Do you know how this can be achived?