Add Flatpak metainfo #2413
Open
Add Flatpak metainfo #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqwxl
force-pushed
the
flatpak-metainfo
branch
2 times, most recently
from
69b0996
to
9a2dfde
Compare
MultisampledNight
approved these changes
Mar 22, 2024
Kethku
reviewed
Mar 22, 2024
| <metadata_license>MIT</metadata_license> | ||
| <project_license>MIT</project_license> | ||
| <developer id="dev.neovide"> | ||
| <name>Kaylee Simmons</name> |
There was a problem hiding this comment.
Does this have to be an individual person? I think it should probably be Neovide Team or something if possible
Kethku
reviewed
Mar 22, 2024
| <content_rating type="oars-1.1"></content_rating> | ||
| <url type="bugtracker">https://github.com/neovide/neovide/issues</url> | ||
| <url type="homepage">https://neovide.dev/index.html</url> | ||
| <url type="contact">https://discord.gg/SjFpZdQys6</url> |
There was a problem hiding this comment.
can there be multiple contact urls? Might be worth including the matrix channel as well https://matrix.to/#/#neovide:matrix.org
fredizzimo
reviewed
Mar 24, 2024
| </description> | ||
| <categories> | ||
| <category>Utility</category> | ||
| <category>TextEditor</category> |
There was a problem hiding this comment.
I think we could add Development here. Kate for example includes that category.
|
Could you also update https://github.com/neovide/neovide/blob/main/assets/neovide.desktop, to make it consistent with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
This relates to #2412 . It adds a top-level directory
flatpakand a flathub metainfo file. This file is intended to be referenced from the flatpak manifest. I initially added it to the Flathub PR (flathub/flathub#5017) but I was told it should be stored upstream.The content's of this file are up for discussion, I just went with common sense for most fields. The referenced Flathub PR includes some comments and requests for changes. In particular, it was asked that we provide a less technical description for the app.