Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native border on floating window #2239

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

TwIStOy
Copy link
Contributor

@TwIStOy TwIStOy commented Jan 5, 2024

What kind of change does this PR introduce?

  • Feature

Did this PR introduce a breaking change?

A breaking change includes anything that breaks backwards compatibility either at compile or run time.

  • No

Draw a rectangle rounding floating windows. Also change color when entering that window.

@TwIStOy TwIStOy marked this pull request as draft January 5, 2024 11:17
@TwIStOy TwIStOy changed the title Draft: Add native border on floating window feat: Add native border on floating window Jan 5, 2024
@TwIStOy TwIStOy changed the title feat: Add native border on floating window feat: add native border on floating window Jan 5, 2024
@fredizzimo
Copy link
Member

I have not reviewed the code yet, but I think this is a good feature.

I'm just not sure about the configuration. It might be good enough for initial support, but I think we eventually should be able to configure this, and the shadows, which are similar, in the same way as native floating window borders. So, that it's window specific and can be applied to just the floating windows that need it.

For that we need to discuss with the Neovim team on what's the best approach. Perhaps, a new setting guiborder, with some defaults. It would also be nice to render the current native borders, using our own renderer. The border propery as it is, is not enough, since it does not allow combining shadows with regular border styles.

@TwIStOy
Copy link
Contributor Author

TwIStOy commented Jan 8, 2024

Yeh, we need some more information about these floating windows from Neovim. It's not easy to determine if the native border should be rendered or not now. This PR now adds a lot of borders on these floating windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants