feat: Add acrylic blur option for background #2104
Conversation
MultisampledNight
changed the title
MultisampledNight
changed the title
| #[cfg(target_os = "windows")] | ||
| window_vibrancy::apply_acrylic(window, Some(blur_color)) | ||
| } else { | ||
| #[cfg(target_os = "windows")] | ||
| window_vibrancy::clear_acrylic(window) |
There was a problem hiding this comment.
It looks like macOS could be supported as well, although we'd need someone with a macOS machine to confirm that.
There was a problem hiding this comment.
Yeah I mentioned this in the issue. I dont know how the macos arguments work and it was late so I just didnt bother. This PR isn't really mergeable as is and should probably be done with a winit upstream change anyway. I just threw it together as an example
|
On Wayland we should use https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_blur where supported |
Kethku
changed the title
|
macOS also supports blur through winit in the latest release https://github.com/rust-windowing/winit/releases/tag/v0.29.3, so on that there's now two alternatives, the |
|
|
|
@Kethku @fredizzimo I guess we could proceed with the macOS blurring I've implemented at #2273 after our fix #2272 gets merged, so we could merge your blurred windows OS based afterwards? the macOS blurring option is really simple to enable and as far as I've using it, works really well with our floating blurred windows. |
|
@Kethku, I think we should implement this totally with winit now. Acryllic backdrop support was added here, and as mentioned earlier, both macOS and Wayland has blur support. It needs this though: |
|
Once wayland is added it should also close this issue |
|
The relevant function hasn't actually been released yet so I'm going to hold off on updating this till that gets in. |
|
Any news regarding this? I don't want to be pushy, just curious. It's also a minor thing, but it's the main thing stopping me from using Neovide, and sticking to using the terminal. |
This is still waiting on an upstream winit release. The necessary code has been merged but not released yet. Plus winit updates in the past have been... tricky. So its gonna be a while yet. Out of our hands for the moment |
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.