Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[request] Acrylic window blur #2078

Open
sravioli opened this issue Oct 12, 2023 · 4 comments
Open

[request] Acrylic window blur #2078

sravioli opened this issue Oct 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@sravioli
Copy link

Is your feature request related to a problem? Please describe.
Not related to a problem, purely an aesthetic request.

Describe the solution you'd like
Would it be possibile to have window transparency in an Acrylic style?

Describe alternatives you've considered
I've seen that tauri has a crate for this. I do not know how hard would it be to implement it from scratch or if it is possible to use said crate. I've also fount this winit issue and a (now closed) pull-request about it.

Additional context
Example (neovim in windows terminal):
image
@sravioli sravioli added the enhancement New feature or request label Oct 12, 2023
@fredizzimo
Copy link
Member

For Wayland we have this issue #1936. And indeed the PR is now merged, so it should just be a matter of updating winit and enabling it here.

But the other platforms still either need Winit support or something else.

@Kethku
Copy link
Member

Kethku commented Nov 4, 2023

The linked tauri crate looks like it could work. Winit implements the necessary trait so it would just require adding a setting. If I have some time I can work on a PR for this. I'd also be happy to advise anybody who wants to take a stab

@Kethku Kethku added help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Nov 4, 2023
@Kethku
Copy link
Member

Kethku commented Nov 6, 2023 •
edited

#2104 Heres a draft PR which uses the linked crate to add the acrylic effect on windows. To merge this it would need to be updated to handle macos and linux properly. Macos is in theory supported but required extra macos specific arguments I wasn't familiar with so I didn't have time to implement it.

Imho this should go in after we figure out how transparency should work. As is its difficult to get an effect that looks good with the background transparencies and floating window layers.

I'm going to leave this PR for now incase somebody wants to push on this and the other transparency issues, but for now I'm dropping it myself

@Kethku Kethku removed the good first issue Good for newcomers label Nov 8, 2023
@MultisampledNight MultisampledNight linked a pull request Nov 10, 2023 that will close this issue
feat: Add acrylic blur option for background #2104
Closed
@fredizzimo fredizzimo mentioned this issue Mar 23, 2024
Closed
@Kethku
Copy link
Member

Kethku commented May 12, 2024

Winit has released. We are now blocked on rust-windowing/glutin#1675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add acrylic blur option for background neovide/neovide
3 participants
@Kethku @fredizzimo @sravioli