remove aws-lc-rs dep and fix storage_broker tls #9613
Merged
+72
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
e513e6f at 2024-11-04T13:21:59.015Z :recycle: |
skyzh
approved these changes
Nov 2, 2024
cloneable
approved these changes
Nov 3, 2024
I've also opened hyperium/tonic#2034 as more robust solution. |
hlinnaka
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Yes please, for a different reason: I just bumped into this issue compiling with cranelift: rust-lang/rustc_codegen_cranelift#1520. I'm sure that'll be eventually fixed, but not using aws-lc-rs avoids it.
Do we need to specify a provider at all? How about using https://docs.rs/rustls/latest/rustls/server/struct.ServerConfig.html#method.builder instead?
|
The pg17 failures do not seem to be flaky. I'm not sure what's changed there |
conradludgate
force-pushed
the
remove-aws-lc-rs
branch
from
a07cbad
to
e513e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the ecosystem is not so keen on moving to aws-lc-rs as it's build setup is more complicated than ring (requiring cmake).
Eventually I expect the ecosystem should pivot to https://github.com/ctz/graviola/tree/main/rustls-graviola as it stabilises (it has a very simply build step and license), but for now let's try not have a headache of juggling two crypto libs.
I also noticed that tonic will just fail with tls without a default provider, so I added some defensive code for that.