-
Notifications
You must be signed in to change notification settings - Fork 537
Dynamic Masking Support for anon
v2
#11733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thesuhas
wants to merge
58
commits into
main
Choose a base branch
from
thesuhas/anon_v2_dynamic_masking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles, one for installation
…ql. Added column names from that
8349 tests run: 7844 passed, 0 failed, 505 skipped (full report)Flaky tests (3)Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2620485 at 2025-05-01T22:53:11.504Z :recycle: |
…andling of anon to audit
MMeent
reviewed
Apr 28, 2025
MMeent
reviewed
Apr 28, 2025
MMeent
reviewed
Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned before, there are IMO too many places where anon
is added by default. I'd rather not add these moving parts by default; AFAIK it is going to be an opt-in feature, and not forced on all users.
ololobus
reviewed
Apr 29, 2025
…ession_preload_libraries are not overwritten
…nto session_preload_libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR works on adding dynamic masking support for
anon
v2. It currently only supports static masking.Summary of changes
Added a security definer function that sets the dynamic masking guc to
true
with superuser permissions.Added a security definer function that adds
anon
tosession_preload_libraries
if it's not already present.Related to: https://github.com/neondatabase/cloud/issues/20456