-
Notifications
You must be signed in to change notification settings - Fork 866
Postgres metrics for stuck getpage requests #11710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If this PR added a GUC in the Postgres fork or If you're an external contributor, a Neon employee will assist in |
8327 tests run: 7827 passed, 0 failed, 500 skipped (full report)Flaky tests (2)Postgres 17
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
56ab95c at 2025-04-28T18:43:20.006Z :recycle: |
60142ea to
39a764a
Compare
compute/etc/sql_exporter/getpage_stuck_requests_total.libsonnet
Outdated
Show resolved
Hide resolved
b42bf49 to
56ab95c
Compare
knizhnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why instead just calculating maximal time we can not just use histogram as for example file_cache_write_hist.
In this In this case we do not need separate counter metrics for stuck requests.
|
I've considered this as an option, but our current latency histogram treats 10s as +Inf, so either adding a new bucket or another metrics. Or you suggest turning max_ metric into a histogram? That's also an option but seems a bit extra for me, as we won't care for any but max values, and most of the histogram would just duplicated the exiting histogram for latencies |
#10327
Resolves: #11720
New metrics:
compute_getpage_stuck_requests_totalcompute_getpage_max_inflight_stuck_time_ms