Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use .Dockerfile as file ext, following best practices from Docker #1296

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

fedordikarev
Copy link
Contributor

@fedordikarev fedordikarev commented Mar 4, 2025

That will allow syntax highlight for the files, and number of utilities expect .Dockerfile to be an ext for the files.

Some projects may need distinct Dockerfiles for specific purposes. A common convention is to name these .Dockerfile. You can specify the Dockerfile filename using the --file flag for the docker build command. Refer to the docker build CLI reference to learn about the --file flag.

https://docs.docker.com/build/concepts/dockerfile/#filename

@fedordikarev fedordikarev changed the title use .Dockerfile as file ext, following best practices from Docker ci/lint: use .Dockerfile as file ext, following best practices from Docker Mar 4, 2025
@fedordikarev fedordikarev changed the title ci/lint: use .Dockerfile as file ext, following best practices from Docker CI: use .Dockerfile as file ext, following best practices from Docker Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

No changes to the coverage.

HTML Report

Click to open

Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@sharnoff
Copy link
Member

sharnoff commented Mar 4, 2025

As a follow-up: @mikhail-sakhnov WDYT about renaming neonvm-kernel/{kernel-builder.Dockerfile => Dockerfile} ? I'm realizing it's a little redundant 😅

@mikhail-sakhnov
Copy link
Contributor

@sharnoff I think it can be just Dockerfile

@fedordikarev
Copy link
Contributor Author

Let me add that rename neonvm-kernel/{kernel-builder.Dockerfile => Dockerfile} here as well

@fedordikarev fedordikarev merged commit 934a7bd into main Mar 4, 2025
35 checks passed
@fedordikarev fedordikarev deleted the feat/rename_dockerfiles branch March 4, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants