Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonvm-controller/ipam: add metrics #1293

Merged
merged 4 commits into from
Mar 7, 2025
Merged

neonvm-controller/ipam: add metrics #1293

merged 4 commits into from
Mar 7, 2025

Conversation

Omrigan
Copy link
Contributor

@Omrigan Omrigan commented Mar 3, 2025

Two metrics:

  • Number of ongoing IPAM operations
  • Duration histogram

Part of #1294.

Copy link

github-actions bot commented Mar 3, 2025

No changes to the coverage.

HTML Report

Click to open

@Omrigan Omrigan force-pushed the oleg/ipam-fixes branch 2 times, most recently from 3d10968 to 04be1a6 Compare March 5, 2025 16:53
@Omrigan Omrigan force-pushed the oleg/ipam-metrics branch from 3531893 to 4f88e7f Compare March 5, 2025 17:04
@Omrigan Omrigan force-pushed the oleg/ipam-fixes branch 4 times, most recently from 5fa0a9e to 2f62bb4 Compare March 6, 2025 22:24
@Omrigan Omrigan force-pushed the oleg/ipam-metrics branch from 4f88e7f to d849b82 Compare March 6, 2025 22:26
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments -- broadly looks good; some ideas for improvement, but nothing critical.

Base automatically changed from oleg/ipam-fixes to main March 7, 2025 14:15
Omrigan and others added 3 commits March 7, 2025 14:28
Co-authored-by: Em Sharnoff <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan Omrigan force-pushed the oleg/ipam-metrics branch from d9d3588 to 2c6397c Compare March 7, 2025 14:28
@Omrigan Omrigan assigned sharnoff and unassigned Omrigan Mar 7, 2025
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo existing comment threads

@sharnoff sharnoff assigned Omrigan and unassigned sharnoff Mar 7, 2025
@Omrigan Omrigan merged commit 6c28e66 into main Mar 7, 2025
35 checks passed
@Omrigan Omrigan deleted the oleg/ipam-metrics branch March 7, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants