Add VirtualMachine overcommit factors #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
sharnoff
requested review from
a team and
Omrigan
and removed request for
a team
This commit adds a new VirtualMachine spec field: Overcommit, which contains resource.Quantity factors for CPU and memory to discount resource usage. It's propagated to the runner via the "vm.neon.tech/overcommit" annotation, which the scheduler plugin and cluster-autoscaler respect, dividing resource usage by the VM's corresponding overcommit factor for that resource, if present. The overcommit factors are also mutable.
sharnoff
force-pushed
the
sharnoff/overcommit-v2
branch
from
bc5544d to
f334acf
Compare
Omrigan
reviewed
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
VirtualMachinespec field:Overcommit, which containsresource.Quantityfactors for CPU and memory to discount resource usage.It's propagated to the runner via the
vm.neon.tech/overcommitannotation, which the scheduler plugin and cluster-autoscaler respect, dividing resource usage by the VM's corresponding overcommit factor for that resource, if present.The overcommit factors are also mutable.
Closes #517, supersedes #905.
Note: This PR builds on #1288 and must not be merged before it.