neonvm-runner: Reduce startup logs #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
petuhovskiy
requested review from
a team and
mikhail-sakhnov
and removed request for
a team
petuhovskiy
requested review from
lassizci
and removed request for
mikhail-sakhnov
lassizci
approved these changes
Feb 25, 2025
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Feb 26, 2025
Bump version to pick up changes introduced in neondatabase/autoscaling#1286 It's better to have a compute release for this change first, because: - vm-runner changes kernel loglevel from 7 to 6 - vm-builder has a change to bring it back to 7 after startup Previous update: #10015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables verbose logging for repetitive startup logs, such as kernel debug boot logs.
It sets default kernel loglevel as INFO (https://docs.kernel.org/core-api/printk-basics.html) and vminit script sets loglevel back to DEBUG after booting has completed.
The full list of changes can be seen in commit messages.
Startup logs before this PR (559 lines): https://gist.github.com/petuhovskiy/cfa0e7654cd25b37247694a33a9d556b
Startup logs after this PR (123 lines): https://gist.github.com/petuhovskiy/a85a7dad7bb4015d2f1f33fcd6cce9fd
Closes https://github.com/neondatabase/cloud/issues/19678