CI: push images to ACR #1285
Merged
CI: push images to ACR #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
force-pushed
the
bayandin/acr
branch
from
c869fdd to
563f652
Compare
bayandin
force-pushed
the
bayandin/acr
branch
2 times, most recently
from
5427741 to
e2afa01
Compare
|
lgtm to me. We might probably want to do the ECR uploading as a separate workflow. |
Eventually, we're going to use a workflow like this from |
mikhail-sakhnov
approved these changes
Feb 26, 2025
bayandin
force-pushed
the
bayandin/acr
branch
from
e2afa01 to
dd318c0
Compare
jcgruenhage
added a commit
that referenced
this pull request
Mar 10, 2025
This reverts commit 8101bab.
jcgruenhage
added a commit
that referenced
this pull request
Mar 10, 2025
This reverts commit 8101bab. The reason for this is a release build failing, see https://github.com/neondatabase/autoscaling/actions/runs/13726698604/job/38434423513. I'll look into re-applying this fix again after the release is cut and fixing the underlying problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins pushing images to ACR (along with ECR) for releases.
.github/workflows/_push-to-acr.yamlworkflow to push images to ACR (copied fromcloudrepo)inputs.upload-to-ecrtoinputs.upload-to-ecr-acr