Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/lint: golangci-lint v1.64.5 #1274

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Conversation

bayandin
Copy link
Member

Bump golangci-lint to the latest version

pkg/reporting/client_azureblob.go:113:39: directive `//nolint:exhaustruct // It's part of Azure SDK` is unused for linter "exhaustruct" (nolintlint)
        opts := azblob.UploadBufferOptions{} //nolint:exhaustruct // It's part of Azure SDK
                                             ^
pkg/reporting/client_azureblobbilling_test.go:82:37: directive `//nolint:exhaustruct // OK for tests` is unused for linter "exhaustruct" (nolintlint)
                                rErr := &azcore.ResponseError{} //nolint:exhaustruct // OK for tests
                                                                ^
pkg/reporting/client_azureblobbilling_test.go:91:40: directive `//nolint:exhaustruct // OK for tests` is unused for linter "exhaustruct" (nolintlint)
                                        &azblob.CreateContainerOptions{}, //nolint:exhaustruct // OK for tests
                                                                          ^
pkg/reporting/client_azureblobbilling_test.go:100:39: directive `//nolint:exhaustruct // OK for tests` is unused for linter "exhaustruct" (nolintlint)
                                        &azblob.DownloadBufferOptions{}, //nolint:exhaustruct // OK for tests
Copy link

github-actions bot commented Feb 18, 2025

No changes to the coverage.

HTML Report

Click to open

@bayandin bayandin changed the title CI(lint): golangci-lint v1.64.5 CI/lint: golangci-lint v1.64.5 Feb 18, 2025
@bayandin bayandin requested review from a team and sharnoff and removed request for a team February 19, 2025 11:44
@bayandin bayandin enabled auto-merge (squash) February 20, 2025 12:45
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for bumping! any ideas why the exhaustruct exemption is no longer necessary for those azure sdk types?

@bayandin bayandin merged commit 181cec4 into main Feb 20, 2025
32 checks passed
@bayandin bayandin deleted the bayandin/golangci-lint-v1.64.5 branch February 20, 2025 13:07
@bayandin
Copy link
Member Author

bayandin commented Mar 3, 2025

any ideas why the exhaustruct exemption is no longer necessary for those azure sdk types?

I don't know, but git-bisedted it to this commit: golangci/golangci-lint@474fdaf (go1.24 support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants