Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonvm-controller: add some migration unit tests #1269

Merged
merged 6 commits into from
Feb 23, 2025
Merged

Conversation

Omrigan
Copy link
Contributor

@Omrigan Omrigan commented Feb 17, 2025

Added some smoke tests and slight refactoring. More is expected.

To be merged with rebase. Tests are in the first commit, so they test the refactoring doesn't break anything.

Part of #1233

@Omrigan Omrigan marked this pull request as draft February 17, 2025 15:29
Copy link

github-actions bot commented Feb 17, 2025

No changes to the coverage.

HTML Report

Click to open

@Omrigan Omrigan force-pushed the oleg/migration-tests branch from 45adb2a to df6f9be Compare February 17, 2025 15:33
Base automatically changed from oleg/seprate-coverage to main February 17, 2025 15:54
@Omrigan Omrigan force-pushed the oleg/migration-tests branch 2 times, most recently from 4639356 to 6457f28 Compare February 17, 2025 17:52
@Omrigan Omrigan marked this pull request as ready for review February 17, 2025 17:57
@Omrigan Omrigan assigned petuhovskiy and unassigned Omrigan Feb 18, 2025
@Omrigan Omrigan closed this Feb 20, 2025
@Omrigan Omrigan reopened this Feb 20, 2025
@petuhovskiy petuhovskiy assigned Omrigan and unassigned petuhovskiy Feb 20, 2025
Omrigan added a commit that referenced this pull request Feb 20, 2025
Omrigan added a commit that referenced this pull request Feb 20, 2025
Omrigan added a commit that referenced this pull request Feb 20, 2025
Omrigan added a commit that referenced this pull request Feb 20, 2025
@Omrigan Omrigan force-pushed the oleg/migration-tests branch from 5979b81 to 5d2d8ef Compare February 20, 2025 13:31
@Omrigan Omrigan enabled auto-merge (rebase) February 20, 2025 13:32
@Omrigan Omrigan disabled auto-merge February 20, 2025 13:32
@Omrigan Omrigan force-pushed the oleg/migration-tests branch from 79c4804 to a916290 Compare February 20, 2025 14:33
@Omrigan Omrigan enabled auto-merge (rebase) February 23, 2025 13:48
@Omrigan Omrigan merged commit 1473aca into main Feb 23, 2025
34 checks passed
@Omrigan Omrigan deleted the oleg/migration-tests branch February 23, 2025 21:42
Omrigan added a commit that referenced this pull request Feb 23, 2025
Omrigan added a commit that referenced this pull request Feb 23, 2025
Omrigan added a commit that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants