Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.1] Implement GHA PR checks #309

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[1.20.1] Implement GHA PR checks #309

merged 1 commit into from
Nov 30, 2023

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Nov 30, 2023 •
edited
Loading

Implement basic CI checks for the 1.20.1 branch, matching what we have in 1.20.2 but adapted to the old buildscript (i.e. with the extra checkAll and checkJarCompatibility).

embeddedt
embeddedt approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct enough. As I understand it, this is only for checking PRs, not for actually releasing versions, so it's low-risk.

@Technici4n Technici4n merged commit 92ea894 into neoforged:1.20.1 Nov 30, 2023
2 checks passed
@Technici4n Technici4n deleted the pr-checks branch November 30, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embeddedt embeddedt embeddedt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Technici4n @embeddedt