Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Add support for double modifier keybinds #2014

Open
wants to merge 3 commits into
base: 1.21.x
Choose a base branch
from

Conversation

ChampionAsh5357
Copy link
Contributor

Closes #2012

Modifies the key lookup code to handle key mappings that use double modifiers (e.g. Ctrl + Shift). Most of the logic just goes towards allowing the key mappings to be pressed in any order while being removed properly from the associated map on release of either modifier.

@ChampionAsh5357 ChampionAsh5357 added bug A bug or error 1.21.4 Targeted at Minecraft 1.21.4 labels Mar 9, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 9, 2025

  • Publish PR to GitHub Packages

Last commit published: fdd898ae8edcd9a3fa01eb2bbd2d1b68dc8b3b22.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #2014' // https://github.com/neoforged/NeoForge/pull/2014
        url 'https://prmaven.neoforged.net/NeoForge/pr2014'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr2014.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr2014
cd NeoForge-pr2014
curl -L https://prmaven.neoforged.net/NeoForge/pr2014/net/neoforged/neoforge/21.4.114-beta-pr-2014-fix-i2012/mdk-pr2014.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Binds are broken since 1.19.2
1 participant