Remove some missed deprecations #1686
Open
+1
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the deprecations were missed in the port to 1.21.2(.3), the two I have removed are
#c:slimeballs
in favour of the new#c:slime_balls
and the oldDeferredRegister.createDataComponents(String)
initalizer as we have the new much more favourable method. Both of these are things that were marked to be removed in 1.21.2 and were not.I did ask about things to remove and another developer mentioned the other
createDataComponents
as it would make better sense for us to get it out as it was only used for a short period of time and the alternate option is a much better option.I also previously looked at removing the fallbacks for the Oxidising and Waxing datamaps which are marked to be removed in 1.21.2 but have not been, however another maintainer said to leave them until 1.22
Another possible removal could be
IEntityExtension.serializeNBT
as this is marked to be removed too and hasn't yet as it doesn't specify a removal period