-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.3] RegisterRenderStateModifiersEvent
and EntityRenderState
extends AttachmentHolder
#1650
Open
dhyces
wants to merge
12
commits into
neoforged:1.21.x
Choose a base branch
from
dhyces:feat/render-state-event
base: 1.21.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fab1b31 - Browse repository at this point
Copy the full SHA fab1b31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3139c92 - Browse repository at this point
Copy the full SHA 3139c92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c5e760 - Browse repository at this point
Copy the full SHA 3c5e760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99600ad - Browse repository at this point
Copy the full SHA 99600adView commit details -
1. Moved callsite to `createRenderState`. This differs from feedback, though I believe is a better location, seeing as the method is final and will apply modifiers if users call the method. 2. Some classes have been renamed to better reflect behavior 3. Use ContextKey instead of custom class 4. Retain each modifier separately so that subclasses may be considered 5. Use lazily evaluated map for storing all modifiers that apply to a given renderer
Configuration menu - View commit details
-
Copy full SHA for f98e132 - Browse repository at this point
Copy the full SHA f98e132View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8ef1cf - Browse repository at this point
Copy the full SHA a8ef1cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b41cdf4 - Browse repository at this point
Copy the full SHA b41cdf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9691504 - Browse repository at this point
Copy the full SHA 9691504View commit details -
Configuration menu - View commit details
-
Copy full SHA for b519839 - Browse repository at this point
Copy the full SHA b519839View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8643b7d - Browse repository at this point
Copy the full SHA 8643b7dView commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48db639 - Browse repository at this point
Copy the full SHA 48db639View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84dacf3 - Browse repository at this point
Copy the full SHA 84dacf3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.