Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] RegisterRenderStateModifiersEvent and EntityRenderState extends AttachmentHolder #1650

Open
wants to merge 12 commits into
base: 1.21.x
Choose a base branch
from

Commits on Nov 11, 2024

  1. Draft for event

    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fab1b31 View commit details
    Browse the repository at this point in the history
  2. Example 1

    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3139c92 View commit details
    Browse the repository at this point in the history
  3. Example 2

    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3c5e760 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99600ad View commit details
    Browse the repository at this point in the history
  5. Apply Tslat's feedback

    1. Moved callsite to `createRenderState`. This differs from feedback, though I believe is a better location, seeing as the method is final and will apply modifiers if users call the method.
    2. Some classes have been renamed to better reflect behavior
    3. Use ContextKey instead of custom class
    4. Retain each modifier separately so that subclasses may be considered
    5. Use lazily evaluated map for storing all modifiers that apply to a given renderer
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f98e132 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a8ef1cf View commit details
    Browse the repository at this point in the history
  7. Spotless

    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b41cdf4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9691504 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b519839 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    8643b7d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Remove lazy map init

    dhyces committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    48db639 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84dacf3 View commit details
    Browse the repository at this point in the history