Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Add method to allow building custom DataGenerator.PackGenerator instances #1624

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

ApexModder
Copy link
Contributor

This pr adds a simple utility method to DataGenerator getPackGenerator which allows constructing custom PackGenerator instances.

Currently the only way to generate a builtin pack is by using getBuiltinDatapack which generates to ./data/<namespace>/datapacks/<path>.
This change allows modders to override this and output their builtin packs to any location they choose, relative to the root pack directory.

Example use case would be generating a builtin resource pack or feature pack (which contains both client and server resources).

@ApexModder ApexModder added enhancement New (or improvement to existing) feature or request 1.21.3 Targeted at Minecraft 1.21.3 labels Oct 24, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 24, 2024

  • Publish PR to GitHub Packages

Last commit published: b94e484d87a8f6bf76a79ec33a7678bf3bac0e08.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1624' // https://github.com/neoforged/NeoForge/pull/1624
        url 'https://prmaven.neoforged.net/NeoForge/pr1624'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1624.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1624
cd NeoForge-pr1624
curl -L https://prmaven.neoforged.net/NeoForge/pr1624/net/neoforged/neoforge/21.3.3-beta-pr-1624-pr-pack-generator-ctor/mdk-pr1624.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant