Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Biome and Structure Modifiers not crash when attempted to be re-applied #1545

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

Basically, the modifiers already know if a biome or structure was modified and ideally should just no-op instead. It doesn't make sense to throw an exception when the exception isn't really helping anyone or preventing any error. Even Commoble, when asked, said there wasn't any strong reason for the exception either
image

So let's just remove the exception and the modifier do nothing if object was already modified. Basically cleanup. Might allow for more niche use case for the modifiers but they have other issues to deal with on their own when recycling registries. Just NeoForge should be one less roadblock

Closes #431

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.21.1 Targeted at Minecraft 1.21.1 labels Sep 15, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Sep 15, 2024

  • Publish PR to GitHub Packages

Last commit published: 123a3bc0bc6ef90fcb3e60c6a3efc285afb73e4d.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1545' // https://github.com/neoforged/NeoForge/pull/1545
        url 'https://prmaven.neoforged.net/NeoForge/pr1545'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1545.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1545
cd NeoForge-pr1545
curl -L https://prmaven.neoforged.net/NeoForge/pr1545/net/neoforged/neoforge/21.1.59-pr-1545-RecycledModifiers/mdk-pr1545.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt
Copy link
Contributor Author

Time to yolo it

@TelepathicGrunt TelepathicGrunt merged commit e8b9d12 into neoforged:1.21.x Sep 30, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neoforge Biome/Structure Modifiers crashes on recycled Frozen Registries
2 participants