Make Biome and Structure Modifiers not crash when attempted to be re-applied #1545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the modifiers already know if a biome or structure was modified and ideally should just no-op instead. It doesn't make sense to throw an exception when the exception isn't really helping anyone or preventing any error. Even Commoble, when asked, said there wasn't any strong reason for the exception either
So let's just remove the exception and the modifier do nothing if object was already modified. Basically cleanup. Might allow for more niche use case for the modifiers but they have other issues to deal with on their own when recycling registries. Just NeoForge should be one less roadblock
Closes #431