Add a way to animate armor models in HumanoidArmorLayer

[GizmoTheMoonPig]

Hello again!

I have a custom armor model that I'm rendering via HumanoidArmorLayer, as it should be. The armor model has some extra bits that I would like to animate to sway, similar to how the player's arms do. There's one small issue though: HumanoidArmorLayer doesn't call setupAnim or prepareMobModel anywhere, making it impossible to do so. I don't really want to handle this through a custom layer as everything else works perfectly, so I drafted up this PR to fix my issue.

This PR adds a new method to IClientItemExtensions that allows for calling animation methods in the armor model if desired. This is called right before the model is rendered, meaning you can manipulate parts of the model (moving or rotating) as you so desire.

Please let me know if anything needs changing or if my documentation needs updating. I'll fix it as soon as I can. Thanks for looking over this!

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[KnightMiner]

I never had issues animating humanoid armor layers using the Forge hook, did something change recently that caused issues?

Remember the method to swap the model from the vanilla model to the modded model takes in the original as a parameter; there is a method I recall using to copy the armor properties over from the old model. See this test mod for reference.

[GizmoTheMoonPig]

copying properties isnt my problem here: getting that to work is straightforward enough. I want to have pieces of the armor animate on their own terms.

For example, take the armor model displayed below: (amphibious armor from the Betweenlands)

The specific use case here is to make the various fins and the whiskers on the model passively swing, not dependent on player movement or anything. This used to be done through the model's setupAnim method (done here), the same way the player's passive arm bob is done or how rotating something like the blaze's rods happens. Now here's the issue: the model's setupAnim is not called anywhere in the armor layer (it used to in 1.12!), meaning animations using things like the limb swing and whatnot isnt possible without doing some wacky workarounds. I would prefer to just be able to call setupAnim in the extensions and call it a day.

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.1.62.