Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RenderGuiLayerEvent.Pre#isGoingToRender(), allowing to determine whenever layer is actually going to render on screen #1505

Open
wants to merge 2 commits into
base: 1.21.x
Choose a base branch
from

Conversation

DBotThePony
Copy link
Contributor

Additionally, adds new RegisterGuiLayersEvent API methods, allowing to specify own "rendering condition" which is visible to other mods in isGoingToRender()

Introduces no breaking changes, everything that is declared as public API is binary compatible.

…whenever layer is actually going to render on screen

Additionally, adds new RegisterGuiLayersEvent API methods, allowing to specify own "rendering condition" which is visible to other mods in isGoingToRender()
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2024

CLA assistant check
All committers have signed the CLA.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@sciwhiz12 sciwhiz12 added enhancement New (or improvement to existing) feature or request 1.21.1 Targeted at Minecraft 1.21.1 labels Aug 31, 2024
@neoforged-compatibility-checks

@DBotThePony, this PR introduces breaking changes.
Unfortunately, this project is not accepting breaking changes right now.
Please revert them before this PR can be merged.
Last checked commit: 7c2b76b8267cfaa2c74ed5a45a97b2297012cfc6.

neoforge (:neoforge)

  • net/neoforged/neoforge/client/event/RenderGuiLayerEvent$Pre
    • <init>(Lnet/minecraft/client/gui/GuiGraphics;Lnet/minecraft/client/DeltaTracker;Lnet/minecraft/resources/ResourceLocation;Lnet/minecraft/client/gui/LayeredDraw$Layer;)V: ⚠ Method was lowered in visibility
  • net/neoforged/neoforge/client/event/RenderGuiLayerEvent$Post
    • <init>(Lnet/minecraft/client/gui/GuiGraphics;Lnet/minecraft/client/DeltaTracker;Lnet/minecraft/resources/ResourceLocation;Lnet/minecraft/client/gui/LayeredDraw$Layer;)V: ⚠ Method was lowered in visibility
  • net/neoforged/neoforge/client/gui/GuiLayerManager$NamedLayer
    • <init>(Lnet/minecraft/resources/ResourceLocation;Lnet/minecraft/client/gui/LayeredDraw$Layer;)V: ❗ API method was removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants