(1.21.x) feat: Add dropShadow support to drawCenteredString and drawScrollingString #1493
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
baileyholl
changed the title
baileyholl
changed the title
baileyholl
changed the title
Matyrobbrt
added
enhancement
XFactHD
requested changes
Aug 30, 2024
| protected abstract void renderWidget(GuiGraphics p_282139_, int p_268034_, int p_268009_, float p_268085_); | ||
|
|
||
| public static void renderScrollingString( | ||
| + GuiGraphics p_281620_, Font p_282651_, Component p_281467_, int p_283621_, int p_282084_, int p_283398_, int p_281938_, int p_283471_, boolean dropShadow |
There was a problem hiding this comment.
More of a nitpick, but can you re-order these overloads like this:
- Original 8-param method
- 8-param method with added shadow parameter
- Original 9-param method
- 9-param method with added shadow parameter
This should make the patch a bit easier to read
| self().drawString(font, string, x - font.width(string) / 2, y, color, dropShadow); | ||
| } | ||
|
|
||
| default void drawCenteredString(Font font, Component p_282456_, int x, int y, int color, boolean dropShadow) { |
There was a problem hiding this comment.
Please use a proper name for the Component parameter
| self().drawString(font, formattedcharsequence, x - font.width(formattedcharsequence) / 2, y, color, dropShadow); | ||
| } | ||
|
|
||
| default void drawCenteredString(Font font, FormattedCharSequence p_281854_, int x, int y, int color, boolean dropShadow) { |
There was a problem hiding this comment.
Please use a proper name for the FormattedCharSequence parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drawCenteredStringmethods and adds a dropShadow param, as vanilla does not expose it.