New translation format system (converting json patches) #1492
+436
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Those 2 are just warnings, they don't block the PR. The other 2 ones in Language do. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@HenryLoenwind, this pull request has conflicts, please resolve them for this PR to move forward. |
sciwhiz12
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a variation of #1470 where the extensive patches of #1134 have almost completely been removed. Instead, "array json" is processed by a plugin registered to the new format registry. All that remains of those patches is one that adds the InsertingContent to the codec and one that preserves the json from the language file for later processing.
That "string json" is available with this is now a mere side effect. The main purpose is (a) to allow mods to register whatever format they want and (b) reduce the extensive and intrusive patches.