Replace NG use by a custom neodev plugin built on top of NFRT and MDG #1485
+2,463
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
shartte
reviewed
Sep 25, 2024
Comment on lines
+42
to
+53
| // Remove src/ sources from the root project. They are used in the neoforge subproject. | ||
| sourceSets { | ||
| main { | ||
| java { | ||
| srcDirs = [] | ||
| } | ||
| resources { | ||
| srcDirs = [] | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Was this previously done in NG?
There was a problem hiding this comment.
Looks like it wasn't necessary because the java plugin wasn't getting applied to the root project? I'm not sure why I had to apply java, I think it's for the neodev plugin. We shouldn't need the neodev plugin for the root project though.
Technici4n
commented
Sep 25, 2024
| @@ -3,6 +3,7 @@ import java.util.regex.Pattern | |||
|
|
|||
| plugins { | |||
| id 'net.neoforged.gradleutils' version '3.0.0' | |||
| id 'net.neoforged.neodev' | |||
There was a problem hiding this comment.
Should probably be apply false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our use of NG by a custom plugin that is based on NFRT and MDG, and lives in the
buildSrc/folder.The main advantages are as follows:
TODO:
io.codechickenvariant.