Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix on CSV Extract from NeoDash #372

Merged
merged 8 commits into from
Apr 2, 2023
Merged

Hotfix on CSV Extract from NeoDash #372

merged 8 commits into from
Apr 2, 2023

Conversation

JonanOribe
Copy link
Contributor

@JonanOribe JonanOribe commented Feb 28, 2023

Partial solution to "CSV Extract from NeoDash adds quotes and leading white space" #363.

The white spacing is solved, but I'm not able to reproduce the quotes problem (I'm trying with different versions of Excel and LibreOffice), so I upload the hotfix but I will continue looking about how to induce a failure with the quotes.

No more leading white spaces on headers or data.

Excel
image

LibreOffice
image

JonanOribe and others added 6 commits February 6, 2023 11:07
Add advanced setting to line charts to turn it into a scatter plot
Add advanced setting to line charts to turn it into a scatter plot
Partial solution to "CSV Extract from NeoDash adds quotes and leading white space" #363.

The white spacing is solved, but I'm not able to reproduce the quotes problem (I'm trying with different versions of Excel and LibreOffice), so I upload the hotfix but I will continue looking about how to induce a failure with the quotes.
Copy link

@NanisTe NanisTe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea. Independent of the data. But numbers on MacOS usually introduces quotes at least as soon as there are comma in text fields and at the same time comma is used as a separator. So there seems to be some algorithm checking on this in Numbers.

Which leads actually to one of my issues, that it would be nice to choose the sperator to be used when exporting a csv in NeoDash.

@nielsdejong
Copy link
Collaborator

Hi @NanisTe , I agree, it would be very nice to have an advanced setting in the table report to choose the seperator.
Perhaps people can choose from ,, ;, or \t as a starting point.

@NanisTe
Copy link

NanisTe commented Mar 11, 2023

@nielsdejong yes those separators would be great to have. Currently we can not use our extracts from NeoDash because they are regularly having issues with the comma.

This was referenced Mar 12, 2023
@nielsdejong
Copy link
Collaborator

Hi @JonanOribe and @NanisTe ,

Thanks for your ideas and work here. @JonanOribe I've extended your branch to include the addition of seperators as well so we can get both in simultaniuously.

@nielsdejong nielsdejong merged commit dc2c201 into neo4j-labs:develop Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants