Improve formatting of multiline ERB #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pelletencate
commented
Jul 4, 2024
lib/erb/formatter.rb
Outdated
Comment on lines
273
to
274
| SyntaxTree.format(code, @line_width) | ||
| width = @line_width - tag_stack.size * 2 | ||
| SyntaxTree.format(code, width) |
There was a problem hiding this comment.
fyi: this fixes part of #55
pelletencate
commented
Jul 5, 2024
| @@ -39,7 +39,7 @@ class Error < StandardError; end | |||
| ATTR = Regexp.union(SINGLE_QUOTE_ATTR, DOUBLE_QUOTE_ATTR, UNQUOTED_ATTR, UNQUOTED_VALUE) | |||
| MULTILINE_ATTR_NAMES = %w[class data-action] | |||
|
|
|||
| ERB_TAG = %r{(<%(?:==|=|-|))\s*(.*?)\s*(-?%>)}m | |||
| ERB_TAG = %r{(<%(?:=|-|#)*)(?:(?!\n)\s)*(.*?)\s*(-?%>)}m | |||
There was a problem hiding this comment.
fyi: (?:(?!\n)\s) matches all whitespace except for newlines. Done this in order to preserve comment indentation on the first line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I totally didn't notice the existence of #7 and did my own implementation of better multiline ERB.
This PR does 2 things:
(Due to the fact that I was adding to repetitive logic, I chose to optimize the case statement. If this is undesirable and we prefer even more repetition, I'm OK with having that refactored back)