Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple conversions #58

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Jay-Karia
Copy link
Contributor

@Jay-Karia Jay-Karia commented Aug 17, 2024

Adds a new feature: Multiple Conversions
Can convert and get multiple commands by calling the function single time

  1. One to many (convert one command into multiple package managers' equivalent)
convertMultiple("npm i next", ["pnpm", "bun"])
// ["pnpm add next", "bun add next"]
  1. Many to one (convert many commands into one 1 package manager's equivalent)
convertMultiple(["npm i eslint", "pnpm add react"], "yarn")
// ["yarn add eslint", "yarn add react"]
  1. Many to many (convert many commands into multiple package managers' equivalent)
convertMultiple(["bun add rollup", "npm i express"], ["yarn", "pnpm"])
/*
[
    ["yarn add rollup", "yarn add express"], 
    ["pnpm add rollup", "pnpm add express"]
]
*/

Closes #56

@Jay-Karia Jay-Karia marked this pull request as ready for review August 18, 2024 11:01
@Jay-Karia Jay-Karia mentioned this pull request Aug 24, 2024
@Jay-Karia
Copy link
Contributor Author

@nebrelbug Can you please review this ?

@nebrelbug
Copy link
Owner

@Jay-Karia I appreciate this PR, but as of right now I'm not convinced that it adds enough value to the package to make it worth the increased size and maintenance. It seems to me like this could be implemented fairly simply by developers. I'll leave this open for a while to see if there's strong interest from the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: add multiple commands conversion
2 participants