-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support KubeSpawner profile_options #2937
base: main
Are you sure you want to change the base?
Conversation
Failing "Local Integration Tests" test unrelated to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Verified it works fine with or without jhub-apps enabled. I would be nice to add a cli validation test, by adding a working config here.
For posterity:
Although one thing to note is, its not fully compatible with jhub-apps as in when you deploy app you can't chose different docker images like you can when you create a jupyterlab.
To make it fully compatible with jhub-apps server options we would need to change the UI in jhub-apps
and use the newly added profile options, but since that's beyond the scope of this PR, its not a blocker.
@Adam-D-Lewis in your docs PR, can you add this as a note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, this will also make the notion of "profiles" and the jupyterlab docker images more clear to new users
@Adam-D-Lewis I included a label to not merge the PR as a freeze in new additions to Nebari until the current release is out. As soon as its out, we can merge this one! |
Reference Issues or PRs
Kubespawner has support to configure various docker images (or other options) per profile. See
profile_options
in their docs. We didn't support it in our Pydantic models so this adds support. I tested it and it worked on my local deployment.I made a companion docs PR as well
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Add this section to a nebari config.
then ensure the profile selection page looks something like
![image](https://private-user-images.githubusercontent.com/23342526/409835376-c6170013-bbeb-49de-a305-0536ac816948.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODAyODMsIm5iZiI6MTczOTU3OTk4MywicGF0aCI6Ii8yMzM0MjUyNi80MDk4MzUzNzYtYzYxNzAwMTMtYmJlYi00OWRlLWEzMDUtMDUzNmFjODE2OTQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAwMzk0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiNTRjMzA2Mjc1Y2Y4NDMyYmRkZTFmMjNlNjg4Zjc5ZDhiOTkwMzI3MGIzMGRmZDdjY2RkODdjMmZhZjY4MmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Ekx148e569a9iwXLBwgRVjye0B8pThJd9k9D1h22nI4)
It works whether or not jhub_apps is enabled.
Any other comments?