Some build cleanup I did when I was trying to get things working. I'm not sure about kitchensink/dist instead of kitchensink/app. I'll ask about that in an issue. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BUILDDIR is now defined inside of the repository folder instead of /tmp for consistency. The BUILDDIR now uses "mkdir -p" so that the intermediate directories are also created if necessary
| # Module to use as XUL app for build | ||
| MODULE="app" | ||
| # Module containing webapp to wrap | ||
| WEBAPPMODULE="kitchensink/app/" | ||
| WEBAPPMODULE="kitchensink/dist" |
There was a problem hiding this comment.
This particular line was already changed in https://github.com/Taytay/webapp-xul-wrapper/commit/70b55b60a3e7fae84d670fdb92a596b7e429fa6c
Could you change it to the exact same line, or revert this line change, so that merge conflicts are avoided?
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the "kitchensink/dist" folder included instead of "kitchensink/app"
The BUILDDIR is now defined inside of the repository folder instead of /tmp for consistency.
The BUILDDIR now uses "mkdir -p" so that the intermediate directories are also created if necessary