Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more specific domain slicing #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adnannextdoor
Copy link

@adnannextdoor adnannextdoor commented Nov 20, 2024

Description

Added an extra level of slicing to the domain part to separate the provider (Second-Level domain) from the ending (Top-Level domain) e.g. splitting gmail.com into gmail (SLD) and .com (TLD).

Fixes #(issue_no)

  • Issue_no: <insert your issue no here>
  • Not applicable

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • New project insert
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Project

  • Your Project Name:

  • Short Description: Provide a short desctiption of your Python project

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • My changes do not produce any warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant