Support zero or multiple signerInfos #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive Not important either way. Signed-off-by: Daniel Axtens <[email protected]>
Signed-off-by: Daniel Axtens <[email protected]>
Signed-off-by: Daniel Axtens <[email protected]>
RFC s 9.1:
o signerInfos is a collection of per-signer
information. There may be any number of elements in the
collection, including zero.
Signed-off-by: Daniel Axtens <[email protected]>
Signed-off-by: Daniel Axtens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nayna,
This supports PKCS#7 signedData messages that have zero or multiple signerInfos.
The multiple signerInfo changes are straightforward, the zero signerInfo ones are more complex. Let me know what you think. Supporting zero signerInfos does involve changing the API - I just don't know how to indicate that the signerInfo is not present otherwise. But I'm open to ideas!!
I'll also review the comments on your PR in the ARMmbed/mbedtls repo and design some tests (and review my code) to make them happy. It'll take me a few days to get to it though. I also want to look at a better way of verifying with multiple signerInfos than just iterating through each of them - I've put that in a comment and I'll work on that later also.
Kind regards,
Daniel