Misc suggestions #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKCS7 signing format is used by OpenPOWER Key Management, which is using mbedtls as its crypto library. This patch adds the limited support of pkcs7 parser and verification to the mbedtls. The limitations are: * Only signed data is supported. * CRLs are not currently handled. * Single signer is supported. Signed-off-by: Daniel Axtens <[email protected]> Signed-off-by: Eric Richter <[email protected]> Signed-off-by: Nayna Jain <[email protected]>
OpenSSL provides APIs to generate only the signted data format PKCS7 i.e. without content type OID. This patch adds support to parse the data correctly even if formatted only as signed data. Signed-off-by: Nayna Jain <[email protected]>
The patch updates CMakeLists.txt to include pkcs7. Signed-off-by: Daniel Axtens <[email protected]>
This patch updates the generate_errors.pl to handle PKCS7 code as well. Signed-off-by: Nayna Jain <[email protected]>
This patch adds the updates generated by running generate_features.pl for pkcs7. Signed-off-by: Nayna Jain <[email protected]>
This allows for pkcs7 fuzz testing with OSS-Fuzz. Signed-off-by: Daniel Axtens <[email protected]> Signed-off-by: Nayna Jain <[email protected]>
This commit adds the static test data generated by commands from Makefile. Signed-off-by: Nayna Jain <[email protected]>
Please apply this as a fixup to the commit that adds the fuzzpkcs7 binary. Signed-off-by: Daniel Axtens <[email protected]>
Signed-off-by: Daniel Axtens <[email protected]>
- rather than having them all depend on pkcs7 in .data, we can have a dependnecy in .function - require sha256 and rsa always, almost all our tests require that and it was getting super verbose - mark tests that require SHA1 or SHA512 as they can be turned off - we need CRL as well as CRT support - check_config.h - as check_config requires CRT_PARSE_C, we don't need to depend on it in the tests Signed-off-by: Daniel Axtens <[email protected]>
naynajain
force-pushed
the
development-pkcs7
branch
from
1be4adf to
7dd07e0
Compare
naynajain
force-pushed
the
development-pkcs7
branch
2 times, most recently
from
7711c84 to
7aaa799
Compare
daxtens
force-pushed
the
development-pkcs7
branch
2 times, most recently
from
ce7e6dc to
fefdffa
Compare
naynajain
force-pushed
the
development-pkcs7
branch
from
a3bc69e to
67812d3
Compare
naynajain
force-pushed
the
development-pkcs7
branch
from
64c1420 to
34f4ae4
Compare
nick-child-ibm
pushed a commit
to nick-child-ibm/mbedtls-1
that referenced
this pull request
May 25, 2021
Write a simple unit test for mbedtls_ecp_muladd(). Add just one pair of test cases. naynajain#2 fails since PR Mbed-TLS#3512. Thanks to Philippe Antoine (catenacyber) for the test case, found by ecfuzzer. Signed-off-by: Gilles Peskine <[email protected]>
nick-child-ibm
force-pushed
the
development-pkcs7
branch
2 times, most recently
from
148281d to
634e305
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
8d37876 to
7db91a8
Compare
nick-child-ibm
pushed a commit
that referenced
this pull request
Feb 22, 2022
Signed-off-by: Minos Galanakis <[email protected]> Co-authored-by: davidhorstmann-arm <[email protected]>
nick-child-ibm
pushed a commit
that referenced
this pull request
Feb 22, 2022
Signed-off-by: Minos Galanakis <[email protected]>
nick-child-ibm
force-pushed
the
development-pkcs7
branch
2 times, most recently
from
f3961df to
e7480e8
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
e7480e8 to
3885ea4
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
3885ea4 to
51ec7a4
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
51ec7a4 to
adf4a43
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
3aeee37 to
a75eed3
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
a75eed3 to
45eed9c
Compare
nick-child-ibm
force-pushed
the
development-pkcs7
branch
from
45eed9c to
62b2d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nayna,
Just a few bits and pieces:
Kind regards,
Daniel