fix(spotify): use SortArtistName for matching - #2377 #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shiokoala <[email protected]>
|
Download the artifacts for this pull request: |
|
Thanks, I'll take a look as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2377
Description (What does the pull request do)
Allows for non-Latin/English artist names to fetch artist image from Spotify.
Changes (What changes were made )
Uses the SortArtistName to match against the result of Spotify artist image request.
The current implementation is untouched, so this process is only relevant if there is no match and should not disturb the artist images that are already being fetched as intended.
PS:
It's my first time contributing to an open source project and I want to learn, so please let me know if there's stuff I could have done better.