Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade datafusion #2056

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Upgrade datafusion #2056

merged 7 commits into from
Nov 17, 2024

Conversation

twitu
Copy link
Collaborator

@twitu twitu commented Nov 12, 2024

Pull Request

Fix changes needed for datafusion v43. Subtle internal change to how String arrays, particularly for trade_id column is read by datafusion.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

Tests were run

Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #2056 will degrade performances by 12.03%

Comparing upgrade-datafusion (e4388e6) with develop (3d8209e)

Summary

❌ 1 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop upgrade-datafusion Change
test_live_clock_utc_now 58 µs 65.9 µs -12.03%

@cjdsellers cjdsellers merged commit 3896902 into develop Nov 17, 2024
11 checks passed
@cjdsellers cjdsellers deleted the upgrade-datafusion branch November 17, 2024 10:13
Pushkarm029 pushed a commit to Pushkarm029/nautilus_trader that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants