Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop skipping pytests unless they currently fail #353

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Stop skipping pytests unless they currently fail #353

merged 2 commits into from
Nov 4, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 28, 2024 •
edited
Loading

  • Add Python type hints to pyttsx3/engine.py
  • Run all tests that currently pass on Linux, macOS, and Windows.
  • Add specific tests for the Apple nsss engine.

@cclauss cclauss force-pushed the more-pytests branch 2 times, most recently from aae31ee to 5ec1fc9 Compare October 30, 2024 14:25
@cclauss cclauss marked this pull request as ready for review October 30, 2024 14:28
@cclauss cclauss changed the title DRAFT: Stop skipping pytests Stop skipping pytests unless they currently fail Oct 30, 2024
This was referenced Oct 30, 2024
Closed
Closed
Closed
@cclauss cclauss force-pushed the more-pytests branch 2 times, most recently from 00685e6 to 2aa8ed2 Compare November 3, 2024 22:45
@cclauss cclauss marked this pull request as draft November 4, 2024 10:01
@cclauss cclauss changed the title Stop skipping pytests unless they currently fail DRAFT: Stop skipping pytests unless they currently fail Nov 4, 2024
@cclauss cclauss changed the title DRAFT: Stop skipping pytests unless they currently fail Stop skipping pytests unless they currently fail Nov 4, 2024
@cclauss cclauss marked this pull request as ready for review November 4, 2024 10:28
@willwade willwade merged commit 5818c59 into nateshmbhat:master Nov 4, 2024
12 checks passed
@cclauss cclauss deleted the more-pytests branch November 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @willwade