Use dict lookup of driver name by sys.platform #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
dict-lookup-of-driver-by-sys.platform
branch
from
b5ef9a2
to
be2aca6
Compare
|
@willwade Ready for review. |
|
Good with me. Let's merge if we can - this and the six PR- then I'll update my branches and push changes so we can fix espeak. My calculator is that espeak would never have passed these tests.. |
willwade
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dict lookup is faster and more readable but the principal advantage is that Python 3.13 adds more
sys.platforms likeandroid,ios, andemscriptenso the reliable expandability of drivers could come in handy.