Resolves #142 for empty save_to_file() on darwin platform (NSSS driver) #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I traced the empty file / hanging behavior to
_busy
state management in the driver proxy. The underlyingNSSpeechSynthesizer
object behaves similarly forsay()
andsave_to_file()
, butsave_to_file()
was not updating the busy and completion states before starting synthesis the way thatsay()
does. The state mismanagement caused the second call tosave_to_file()
to start an event loop that would never be terminated.The intentions of the state management in the driver proxy are not perfectly clear to me, so this may not be a completely robust fix, but it does resolve the hanging behavior. Please note that you still must save
.aiff
or.wav
files with the NSSS driver, not.mp3
.