1992 add ability to log at multiple rates#1993
Merged
sharmeye merged 11 commits intonasa:masterfrom Dec 4, 2025
Merged
Conversation
…k that a rate can be represented by the time tic value correctly.
…but restart is after that time is already processed. Set next tics to be after curr tics
hchen99
reviewed
Nov 3, 2025
|
|
||
| // Account for the fact that the current time tics is actually already passed for a checkpoint. | ||
| long long curr_tics = exec_get_time_tics(); | ||
| for(size_t cycleIndex = 0; cycleIndex < logging_next_tics.size(); ++cycleIndex) |
Contributor
There was a problem hiding this comment.
How about creating a helper function to update logging schedule based on the given curr_tics since the code after curr_tics is the same as in data_record(double in_time)?
Contributor
|
Also, maybe add a simple test case using multi-rate recording to SIM_checkpoint_data_recording ;-) |
brendan-nasa
reviewed
Nov 4, 2025
hchen99
reviewed
Nov 4, 2025
| long long calculate_next_logging_tic(); | ||
|
|
||
| /** | ||
| * Vector of next integration time in tics for each rate in the integRates vector |
Contributor
There was a problem hiding this comment.
Comments copied from the multi-rate integrator ;-)
Contributor
Author
There was a problem hiding this comment.
not fixed. found more.. lol
…elf-scheduled for multirate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1992