Skip to content

Not to overwrite the remaining comment with an empty string during comment parsing.#1983

Merged
sharmeye merged 1 commit intomasterfrom
1981-s_sieresource-field-descriptions
Oct 28, 2025
Merged

Not to overwrite the remaining comment with an empty string during comment parsing.#1983
sharmeye merged 1 commit intomasterfrom
1981-s_sieresource-field-descriptions

Conversation

@hchen99
Copy link
Copy Markdown
Contributor

@hchen99 hchen99 commented Oct 22, 2025

Avoid overwriting the remaining comment (after io and unit specs parsing) with an empty string during comment parsing. The function for removing */ when there is no */ returns an empty string. When the variable using // for its comment that may have io, units, and description specs, the var description could be cleared unintentionally.

@hchen99 hchen99 linked an issue Oct 22, 2025 that may be closed by this pull request
Comment thread trick_source/codegen/Interface_Code_Gen/FieldDescription.cpp
@sharmeye sharmeye merged commit 6c2bcd5 into master Oct 28, 2025
12 of 13 checks passed
@sharmeye sharmeye deleted the 1981-s_sieresource-field-descriptions branch October 28, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S_sie.resource Field Descriptions

3 participants