-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
152 make tensor flow optional #154
Conversation
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
Unfortunately, the way things are setup the new test config will not take effect until this is merged. So surrogates and data tests will fail and have to be tested manually |
Seems to mostly be working, but I do get this error on (I think) all of the tensorflow tests:
Could be related to the fact that I am running this in Windows WSL? |
Well that's frustrating. It should be working on windows. But tensorflow is VERY sensitive to os and version. I'll open a new issue to investigate that. I'll also be updating to use keras 3 for this release. That might fix this issue too. But I'll open a bug report to track it |
This PR accomplishes 2 things
Now to install with tensorflow you must use the following command
pip install progpy[datadriven] or pip install '.[datadriven]' (for local copy)
Also updated LSTM to give a more descriptive error if tensor flow isn't installed and updated documentation of LSTM to add note.
How to test: