-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Closes #146] Simulation/Prediction Ending Strategy #149
[Closes #146] Simulation/Prediction Ending Strategy #149
Conversation
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #149 +/- ##
==========================================
- Coverage 83.41% 83.40% -0.01%
==========================================
Files 100 100
Lines 10462 10601 +139
==========================================
+ Hits 8727 8842 +115
- Misses 1735 1759 +24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran with the SWS model and the shell script driving prog_server. Looks to be working. Thanks for the feature!
Add a method of specifying a "strategy" for ending simulation and prediction. This is called the "event_strategy", and can be one of the following:
'first': Stop when the first event of the list is met
'all': Stop when all events in the list are met
Also added tests and added to tutorial.
Note: UTP is setup to only support 'all'. If you specify anything else, it will return an error. #150 opened to eventually add this functionality