Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to UAV model #125

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Updates to UAV model #125

merged 2 commits into from
Dec 1, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Dec 1, 2023

Specifically,

  • Moving properties mass, dynamics, etc. into parameters - this is important for pickleability
  • Update visualize trajectory to work without reference trajectory (just plots predicted trajectory)
  • Update visualize trajectory to support prefix (allows it to be used with Composite Models)

Copy link

github-actions bot commented Dec 1, 2023

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (523e653) 83.37% compared to head (62e92b3) 83.36%.

Files Patch % Lines
...c/progpy/models/aircraft_model/small_rotorcraft.py 56.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
- Coverage   83.37%   83.36%   -0.01%     
==========================================
  Files         100      100              
  Lines       10427    10428       +1     
==========================================
  Hits         8693     8693              
- Misses       1734     1735       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small edits to move a few properties into parameters for ease with pickling

@teubert teubert merged commit 28dd429 into dev Dec 1, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants