Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixture of Experts Model #108

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Mixture of Experts Model #108

merged 4 commits into from
Oct 13, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Oct 11, 2023

First draft mixture of experts model.

This model combines multiple models. Each composite model is propogated in tandem but only the "best" one is used in output/event_state/etc.

@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and the tests are sufficient and run. Added a few suggestions for clarification. Looking forward to seeing an example

src/progpy/mixture_of_experts.py Outdated Show resolved Hide resolved
src/progpy/mixture_of_experts.py Outdated Show resolved Hide resolved
src/progpy/mixture_of_experts.py Outdated Show resolved Hide resolved
src/progpy/mixture_of_experts.py Show resolved Hide resolved
src/progpy/mixture_of_experts.py Outdated Show resolved Hide resolved
@teubert teubert merged commit ac51178 into dev Oct 13, 2023
29 checks passed
@teubert teubert deleted the 20-mixtureofexperts-model branch October 13, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants