Custom event example #105
Merged
Custom event example #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
teubert
approved these changes
Oct 11, 2023
examples/04_New Models.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "There are three components of the model that must be specified in order to define events:\n", |
There was a problem hiding this comment.
Do we want to mention that 2 and 3 are and/or. That is, you can choose to only specify threshold_met or event_state, but often it is beneficial to do both.
There was a problem hiding this comment.
Good idea. I'll add something and you can take a look
examples/04_New Models.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "class Batt_newEvent(BatteryElectroChemEOD):\n", |
There was a problem hiding this comment.
The casing is a bit awkward to me. Can we call it Batt_NewEvent or BattNewEvent?
Codecov Report
@@ Coverage Diff @@
## dev #105 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 99 99
Lines 10183 10183
=======================================
Hits 8574 8574
Misses 1609 1609 |
teubert
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding example of creating new events in notebook 04. New Models